Add missing include file for std::atomic (required by slow_test) #3977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rate_observer class needs the include file because it constructs an
atomic object on 'std::atomic<bool> stopped{ false };'
thsfs
force-pushed
the
fix_rate_observer
branch
from
74cdeb9
to
4960c7b
Compare
dsiganos
approved these changes
Oct 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
slow_testmay not build without the include header for std::atomic.It is required for rate_observer class because it constructs an atomic object on 'std::atomic stopped{ false };'
Got an error for this when building on Ubuntu 22.04 with clang-14.