Remove vote-by-block support from vote class #3813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moving support for vote-by-block.
…milar to the ones actually used. These show up as dead code in coverage scans. https://coveralls.io/builds/48728513/source?filename=nano%2Fsecure%2Fcommon.cpp#L687
…y-block which is not currently emitted. The existing implementation was problematic, modeled as a vector-of-variants rather than a variant of a block and hash vector. It also disallowed behavior that can be correctly encoded, such as empty vote-by-hash votes. Fixing this abstraction inversion was more difficult that simply removing vote by block since this path also introduced its own complexity.
clemahieu
force-pushed
the
remove_vote_by_block
branch
from
9163cfd
to
aeed10f
Compare
thsfs
reviewed
May 9, 2022
…antics of what's being returned and added documentation to function.
thsfs
approved these changes
May 9, 2022
dsiganos
added a commit
to dsiganos/nano_protocol
that referenced
this pull request
Aug 5, 2022
The node is not using such votes for some time now and it now dropped support for parsing them: nanocurrency/nano-node#3813
dsiganos
added a commit
to dsiganos/nano_protocol
that referenced
this pull request
Aug 6, 2022
The node is not using such votes for some time now and it now dropped support for parsing them: nanocurrency/nano-node#3813
dsiganos
added a commit
to nanocurrency/protocol
that referenced
this pull request
Aug 6, 2022
The node is not using such votes for some time now and it now dropped support for parsing them: nanocurrency/nano-node#3813
dsiganos
added a commit
to nanocurrency/protocol
that referenced
this pull request
Jan 25, 2023
The node is not using such votes for some time now and it now dropped support for parsing them: nanocurrency/nano-node#3813
This was referenced Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing implementation was problematic, modeled as a vector-of-variants rather than a variant of a block and hash vector. It also disallowed behavior that can be correctly encoded, such as empty vote-by-hash votes.