Extracting nano::bootstrap::block_deserializer class #3812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsfs
reviewed
May 6, 2022
thsfs
reviewed
May 6, 2022
clemahieu
force-pushed
the
block_deserializer
branch
from
74c05ca
to
424b437
Compare
dsiganos
reviewed
May 7, 2022
thsfs
previously requested changes
May 17, 2022
clemahieu
force-pushed
the
block_deserializer
branch
from
4523b11
to
94cdae7
Compare
…ails, the node will not be shut down and can result in other tests failing further on.
…ixed block streams.
clemahieu
force-pushed
the
block_deserializer
branch
from
1ab546c
to
ef0c9b2
Compare
pwojcikdev
reviewed
Jul 15, 2022
clemahieu
force-pushed
the
block_deserializer
branch
from
ef0c9b2
to
5efaf3c
Compare
clemahieu
force-pushed
the
block_deserializer
branch
from
5efaf3c
to
946fc1c
Compare
pwojcikdev
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code to deserialize type-prefixed blocks from a stream was tightly coupled to the legacy bootstrap process. This prevented direct testing or reuse of block deserialization code.
Rewriting existing bulk_pull_client in terms of the new block deserializer.