Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add optional offset parameter for the receivable RPC #3700

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Add optional offset parameter for the receivable RPC #3700

merged 1 commit into from
Feb 3, 2022

Conversation

Exxenoz
Copy link
Contributor

@Exxenoz Exxenoz commented Jan 31, 2022

Closes #3699

@zhyatt zhyatt added this to the V24.0 milestone Jan 31, 2022
@zhyatt zhyatt added enhancement rpc Changes related to Remote Procedure Calls labels Jan 31, 2022
@Exxenoz Exxenoz force-pushed the rpc_add_offset_to_receivable branch from 3197828 to 5ebf7c6 Compare February 3, 2022 13:42
@Exxenoz
Copy link
Contributor Author

Exxenoz commented Feb 3, 2022

@dsiganos I forgot to add some small tweaks to the sorting case. Build and tests should be working now.

@clemahieu clemahieu added the documentation This item indicates the need for or supplies updated or expanded documentation label Feb 3, 2022
@clemahieu clemahieu merged commit 9b24669 into nanocurrency:develop Feb 3, 2022
@dsiganos
Copy link
Contributor

dsiganos commented Feb 3, 2022

This looks good but we should really have a unit test for this too.

@zhyatt
Copy link
Collaborator

zhyatt commented Feb 3, 2022

This looks good but we should really have a unit test for this too.

@dsiganos Is the unit test done here https://github.com/nanocurrency/nano-node/pull/3700/files#diff-b053a0c38b909565d0ba60ffdfec20e375bb648c815b8088b9c51e6ed22cc71cR1862 incomplete or need to be broken out into a separate test?

@dsiganos
Copy link
Contributor

dsiganos commented Feb 3, 2022 •
edited
Loading

Doh! I missed that! We are good.

@Exxenoz Exxenoz mentioned this pull request Feb 8, 2022
Merged
@zhyatt zhyatt mentioned this pull request Mar 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemahieu clemahieu clemahieu approved these changes

Assignees
No one assigned
Labels
documentation This item indicates the need for or supplies updated or expanded documentation enhancement rpc Changes related to Remote Procedure Calls
Projects
None yet
Milestone
V24.0
Development

Successfully merging this pull request may close these issues.

Add optional offset parameter for the receivable RPC
4 participants
@Exxenoz @dsiganos @zhyatt @clemahieu