Use OS picked ports in core_test
#3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theohax
force-pushed
the
zzz-introduce-os-picked-ports-support
branch
2 times, most recently
from
6a89397
to
a7d0895
Compare
theohax
force-pushed
the
zzz-use-os-picked-ports-in-core-tests
branch
from
f933734
to
5182950
Compare
clemahieu
approved these changes
Dec 1, 2021
theohax
added a commit
that referenced
this pull request
Dec 13, 2021
theohax
added a commit
that referenced
this pull request
Dec 14, 2021
* Introduce support for binding sockets to ports picked by the OS * Use ports picked by OS in all core_test unit tests (#3555) * Rebase branch and address code review * Formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR leverages #3554 for the
core_testunit tests in the sense that all unit tests now rely on ports picked by the OS (for peering and websocket at least) instead of relying on thenano::get_available_portfunctionality.The PR is based off (and target towards) #3554 for easier reviewing and not having to wait until one gets merged to open the second.