Remove callbacks passed through start_tcp #3443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsiganos
previously approved these changes
Sep 13, 2021
Removes usage of start_tcp callback and replace it with simple polling for an established connection.
… queried via an observer set in rep_crawler::rep_crawler.
…_fallback. Directly call send_keepalive in place of using this callback.
clemahieu
force-pushed
the
cleanup_establish_tcp
branch
from
c554e58
to
e1786a4
Compare
|
I already reviewed this, has anything changed? |
No, I just rebased conflicts. |
theohax
approved these changes
Sep 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This series of commits removes callbacks from start_tcp and other associated functions.
These callbacks were mostly used to get one-off functionality in various tests.
One usage was in UDP fallback which is now done directly instead of through a callback.