Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing static initialization order on Window #3206

Merged
merged 1 commit into from
Apr 18, 2021
Merged

Fixing static initialization order on Window #3206

merged 1 commit into from
Apr 18, 2021

Conversation

clemahieu
Copy link
Contributor

No description provided.

@clemahieu
Fixing static initialization order on Windows using construct-on-firs…
f58ec9b 
…t-use.

Fix discarded out of bounds memory access.
theohax
theohax approved these changes Apr 17, 2021
View reviewed changes
Copy link
Contributor

@theohax theohax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Static initialization order fiasco at its finest :D

@clemahieu clemahieu merged commit 6b994b2 into develop Apr 18, 2021
@zhyatt zhyatt deleted the static_initializer_fix branch September 21, 2021 21:51
@zhyatt zhyatt added this to the V22.0 milestone Nov 23, 2021
@zhyatt zhyatt added the bug label Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theohax theohax theohax approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
V22.0
Development

Successfully merging this pull request may close these issues.
3 participants
@clemahieu @theohax @zhyatt