Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CLI commands missing checks for reading config and overrides #3050

Merged
merged 4 commits into from
Mar 8, 2021
Merged

Update CLI commands missing checks for reading config and overrides #3050

merged 4 commits into from
Mar 8, 2021

Conversation

wezrule
Copy link
Contributor

@wezrule wezrule commented Nov 16, 2020 •
edited
Loading

--vacuum & --snapshot was not checking --config overrides.
--debug_profile_votes & --debug_profile_frontiers_confirmation were not checking config file or --config overrides.

Created a new node_wrapper class which refactors most of inactive_node except the part about stopping active transactions because --debug_profile_votes requires active transactions to be running

@wezrule wezrule added the cli Changes related to the Command Line Interface label Nov 16, 2020
@wezrule wezrule added this to the V22.0 milestone Nov 16, 2020
@wezrule wezrule self-assigned this Nov 16, 2020
@wezrule wezrule changed the title Update missing CLI commands to check config and flags Update CLI commands missing checks for reading config and overrides Nov 16, 2020
argakiig
argakiig previously approved these changes Nov 17, 2020
View reviewed changes
SergiySW
SergiySW reviewed Jan 27, 2021
View reviewed changes
nano/nano_node/entry.cpp Outdated Show resolved Hide resolved
SergiySW
SergiySW previously approved these changes Feb 1, 2021
View reviewed changes
@wezrule wezrule requested a review from SergiySW February 2, 2021 10:03
@wezrule wezrule merged commit b30bffe into nanocurrency:develop Mar 8, 2021
@wezrule wezrule deleted the update_cli branch March 8, 2021 13:34
deusmax pushed a commit to deusmax/nano-node that referenced this pull request Mar 16, 2021
@wezrule @deusmax
Update CLI commands missing checks for reading config and overrides (n…
79c92db 
…anocurrency#3050)

* Update missing CLI commands to check config and flags

* Serg comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemahieu clemahieu clemahieu approved these changes

@argakiig argakiig argakiig approved these changes

@SergiySW SergiySW SergiySW approved these changes

Assignees

@wezrule wezrule

Labels
cli Changes related to the Command Line Interface
Projects
None yet
Milestone
V22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wezrule @clemahieu @argakiig @SergiySW