Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to include votes in confirmation websocket #3016

Merged
merged 14 commits into from
Mar 9, 2021
Merged

Add option to include votes in confirmation websocket #3016

merged 14 commits into from
Mar 9, 2021

Conversation

SergiySW
Copy link
Contributor

@SergiySW SergiySW commented Oct 23, 2020 •
edited
Loading

core_test requires client upgrade for message fragmentation.

Subscription: include_election_info_with_votes

Response

{
    ...
    "election_info": {
        ...
       "votes": [
        {
           "representative": "nano_3e3j5tkog48pnny9dmfzj1r16pg8t1e76dz5tmac6iq689wyjfpiij4txtdo",
           "timestamp": "1",
           "sequence": "1",
           "hash": "E7863115D9CBF0EF74E4454E49B536D16CF88EBDF8950D0D2F625F78EF6E9FC1",
           "weight": "280282366920938463463374607431768211454"
       },
        {
           "representative": "nano_3e3j5tkog48pnny9dmfzj1r16pg8t1e76dz5tmac6iq689wyjfpiij4txtdo",
           "timestamp": "2",
           "sequence": "2",
           "hash": "E7863115D9CBF0EF74E4454E49B536D16CF88EBDF8950D0D2F625F78EF6E9FC1",
           "weight": "280282366920938463463374607431768211454"
       }
   ]
}

@SergiySW SergiySW added documentation This item indicates the need for or supplies updated or expanded documentation websockets labels Oct 23, 2020
@SergiySW SergiySW self-assigned this Oct 23, 2020
@zhyatt zhyatt added this to the V22.0 milestone Oct 26, 2020
@SergiySW SergiySW marked this pull request as ready for review November 2, 2020 15:47
@SergiySW SergiySW requested a review from wezrule November 2, 2020 15:47
@zhyatt zhyatt mentioned this pull request Nov 6, 2020
Closed
6 tasks
wezrule
wezrule previously approved these changes Dec 2, 2020
View reviewed changes
argakiig pushed a commit that referenced this pull request Dec 18, 2020
Add option to include votes in confirmation websocket #3016
c7da151
@SergiySW SergiySW requested a review from wezrule January 5, 2021 19:55
wezrule
wezrule previously approved these changes Jan 7, 2021
View reviewed changes
argakiig pushed a commit that referenced this pull request Jan 11, 2021
Add option to include votes in confirmation websocket #3016
79e5321
@SergiySW SergiySW requested a review from wezrule January 27, 2021 05:19
@zhyatt zhyatt mentioned this pull request Feb 9, 2021
Closed
20 tasks
wezrule
wezrule previously approved these changes Mar 3, 2021
View reviewed changes
@SergiySW SergiySW requested a review from wezrule March 8, 2021 16:37
@SergiySW SergiySW merged commit 26b86d1 into nanocurrency:develop Mar 9, 2021
deusmax pushed a commit to deusmax/nano-node that referenced this pull request Mar 16, 2021
@SergiySW @deusmax
Add option to include votes in confirmation websocket (nanocurrency#3016
57c6460 
)

* Add option to include votes in confirmation websocket
core_test requires client upgrade for message fragmentation.
Subscription: include_election_info_with_votes

* Allow votes usage outside of test network
* Remove legacy sequence from new WS subscription
* Apply Wesley review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemahieu clemahieu clemahieu approved these changes

@wezrule wezrule wezrule approved these changes

Assignees

@SergiySW SergiySW

Labels
documentation This item indicates the need for or supplies updated or expanded documentation websockets
Projects
None yet
Milestone
V22.0
Development

Successfully merging this pull request may close these issues.
4 participants
@SergiySW @clemahieu @wezrule @zhyatt