Wallets search pending deadlock #2983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids a dependency inversion as node::receive_confirmed searches all wallets. wallet::search_pending we already know the wallet responsible for receiving that block.
wezrule
previously approved these changes
Sep 25, 2020
wezrule
approved these changes
Sep 25, 2020
guilhermelawless
pushed a commit
to guilhermelawless/nano-node
that referenced
this pull request
Sep 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only an issue in develop. Two different paths can deadlock:
node::search_pending -> wallets::search_pending_all -> wallets mutex lock -> wallet::search_pending -> node::receive_confirmed -> wallets mutex lockRPC -> wallets::search_pending -> wallets mutex lock -> wallet::search_pending -> node::receive_confirmed -> wallets mutex lockThis fixes the deadlock by unlocking the wallets mutex before calling
wallet::search_pending, as there is no need to hold it. But also notes that callingnode::receive_confirmedfrom the wallet is a dependency inversion. There's no need to search for the wallet again and we are sure the block exists, soreceive_asynccan be directly called.@SergiySW note this means pruning #2881 (I don't think this part has been split yet) will have to consider this new case in
wallet::search_pending, not only innode::receive_confirmed.The added unit test is identical to the existing wallet.search_pending but is now done for wallets