Add time retrieval latency profile to CLI diagnostics #2844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guilhermelawless
added
the
debug
SergiySW
approved these changes
Jul 14, 2020
wezrule
approved these changes
Jul 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A slower clocksource can have significant impact on the performance of the node. I was faced with this issue in a laptop with unstable TSC which falls back to the slower HPET (almost two orders of magnitude slower).
The cause wasn't immediately apparent, only after profiling, so this PR adds a quick loop to
--diagnosticsto measure the latency in retrieving the current system time. The loop isn't optimized away even in O3. Only takes ~100ms total with TSC.For reference: