Allow unescaped quoted strings with --config CLI #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
argakiig
previously approved these changes
Jul 1, 2020
wezrule
changed the title
wezrule
force-pushed
the
cli_config_parsing_error
branch
from
0b9d4e1
to
5688c07
Compare
There was a problem hiding this comment.
Tested:
- node.active_elections_size
- node.httpcallback.address
- node.max_work_generate_multiplier
- node.work_peers
No regressions and all of them now work with unescaped quotes or even no quotes.
However noticed on arrays like node.work_peers it's not possible to give --config node.work_peers=["127.0.0.1:7000"] , the quotes must be escaped instead: --config node.work_peers=[\"127.0.0.1:7000\"].
Using the approach of this PR, can this case be handled? If not, LGTM but the documentation should note this particular case.
|
@guilhermelawless I have added support for arrays, thanks for finding that during testing. |
wezrule
added
the
documentation
guilhermelawless
approved these changes
Jul 16, 2020
zhyatt
added
breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task was originally because of confusion around this error found by @guilhermelawless:
./nano_node --network live --daemon --config node.online_weight_minimum="40000000000000000000000000000000000000"The docs state that strings should be escaped. Would be nice if non-escaped quotes could be done which is what this PR has added.
To solve this we are now separating the key and value, then appending them together with the value being surrounded in escaped quotations if they are not added by the command. Toml seems to be able to handle this fine based on various tests. Reviewers should test a variety of options with different types (bool/int/string for instance).