Vote spacing #2763
Merged
Vote spacing #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhyatt
added
the
quality improvements
guilhermelawless
previously approved these changes
May 8, 2020
There was a problem hiding this comment.
Added some tests to ensure full coverage. This showed a small consistency problem, now fixed by updating reservations after vote generation in edd9dd3. LGTM.
SergiySW
reviewed
May 8, 2020
SergiySW
reviewed
May 8, 2020
clemahieu
force-pushed
the
vote_spacing
branch
3 times, most recently
from
9b2870c
to
0994989
Compare
…r root and this can lead to increased, unnecessary vote traffic. This patch adds a delay between constructing non-cached votes.
clemahieu
force-pushed
the
vote_spacing
branch
from
0994989
to
637ecd9
Compare
wezrule
previously approved these changes
Nov 19, 2020
clemahieu
force-pushed
the
vote_spacing
branch
from
a67eaf9
to
fae170c
Compare
SergiySW
previously approved these changes
Nov 20, 2020
… filters by root+hash so it won't pick up votes for hashes it's not looking for.
…y::votes filters by root+hash so it won't pick up votes for hashes it's not looking for." This reverts commit 9890305.
# Conflicts: # nano/core_test/request_aggregator.cpp
wezrule
suggested changes
Dec 29, 2020
wezrule
previously approved these changes
Jan 11, 2021
…t not be generated.
argakiig
approved these changes
Jan 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is no rate limiter on vote generation for a particular root and this can lead to increased, unnecessary vote traffic.
The nano::vote_reserver class was created to track the last time a vote was generated for a particular root.
In order to accurately and globally throttle votes, all vote generation was moved to vote_generator::vote and should not be done elsewhere.
nano::vote_generator processes two separate vote pipelines: live traffic and requests.