-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add block and voters count in election information #2414
Add block and voters count in election information #2414
Conversation
Most likely for a separate PR: I think you raise a good point about try_lock, even if it's in an assert. I know it's already done a couple of places, but |
Agree 100%, see issue 2415 for tracking this. One glaring location is |
a1430b0
Considered adding more details such as the number of votes for each block, but would need to tally up each election.
Similar to a previous PR, uses
assert (!node.active.mutex.try_lock ());
which can have undefined behavior, but only used in Debug. Don't see an easy alternative in this case, and it was already used inelection.cpp
.