Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix occasional failures for core_test.distributed_work* tests #2392

Merged

Conversation

guilhermelawless
Copy link
Contributor

Fixes failures such as: https://travis-ci.org/nanocurrency/nano-node/jobs/607767045#L3209

Ran 300 times under Debug TSAN on Linux, would be good to check on OSX which is where it failed sometimes

@guilhermelawless guilhermelawless added the unit test Related to a new, changed or fixed unit test label Nov 6, 2019
@guilhermelawless guilhermelawless added this to the V20.0 milestone Nov 6, 2019
@guilhermelawless guilhermelawless self-assigned this Nov 6, 2019
Copy link
Contributor

@wezrule wezrule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran all distributed_work tests 100 times on MacOS, no failures

@wezrule wezrule merged commit 2f4d4a1 into nanocurrency:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
unit test Related to a new, changed or fixed unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants