Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect total memtable size used with RocksDB #2390

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nano/node/rocksdb/rocksdb.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -456,7 +456,7 @@ rocksdb::Options nano::rocksdb_store::get_db_options () const
// Sets the compaction priority
db_options.compaction_pri = rocksdb::CompactionPri::kMinOverlappingRatio;

// Start agressively flushing WAL files when they reach over 1GB
// Start aggressively flushing WAL files when they reach over 1GB
db_options.max_total_wal_size = 1 * 1024 * 1024 * 1024LL;

// Optimize RocksDB. This is the easiest way to get RocksDB to perform well
Expand All @@ -467,7 +467,7 @@ rocksdb::Options nano::rocksdb_store::get_db_options () const
db_options.enable_pipelined_write = rocksdb_config.enable_pipelined_write;

// Total size of memtables across column families. This can be used to manage the total memory used by memtables.
db_options.db_write_buffer_size = rocksdb_config.total_memtable_size;
db_options.db_write_buffer_size = rocksdb_config.total_memtable_size * 1024 * 1024ULL;

return db_options;
}
Expand Down