Vacuum after upgrade #2370
Merged
Vacuum after upgrade #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
added
the
quality improvements
argakiig
approved these changes
Oct 29, 2019
guilhermelawless
approved these changes
Oct 30, 2019
argakiig
pushed a commit
that referenced
this pull request
Oct 31, 2019
* Vacuum after upgrade * Modify vacuum failed log message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the v14 to v15 database upgrade, the ledger grows from 16GB to 24GB, vacuuming is now done after the upgrade. Vacuuming can take substantial time on lower end devices, for instance my 1vCPU, 2GB Ram droplet took 16 minutes for the upgrade itself (swap space was not used) and a further 20 minutes for the vacuum. On Windows, 3.4GHZ, 16GB RAM, the upgrade and vacuum took under 10 minutes in total, both tests were done with the RelWithDebInfo configuration. Additional log entries were added near the beginning upgrade steps. The following was logged for the 1vCPU droplet where it didn't have enough space for the vacuum (only difference is the last log entry which would say successful if it was):