Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
representation_add ()
inledger.cpp
. It has an unusednano::transaction
parameter and calling the contents of the function (1 line) directly where it's used seems cleaner than the extra indirection of this function.Removed multi-line commented section of code in
core_test/epochs.cpp
. It references an epoch_2 which doesn't currently exist, so will just confuse anyone looking at it.nano/secure/CMakeLists.txt
to be consistent with the rest of the file the header goes before the source file.The confirmation height processor now has a dependency on the ledger class and the constructor is passed a
cemented_count
cache from the ledger, this can just be called from the ledger object directly now, no need to pass it in.Some functions in ledger/epoch can return
const &
to avoid a copy.Using
auto
to simplify some lambda parameters inepoch.cpp
and pass thelink
capture by reference