Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distibuted work fixes #2230

Merged
merged 17 commits into from
Aug 23, 2019
Merged

Distibuted work fixes #2230

merged 17 commits into from
Aug 23, 2019

Commits on Aug 20, 2019

  1. Fix work_cancel not being sent and some unreachable peers hanging the… 

    … requests
    @guilhermelawless
    guilhermelawless committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    6f17391 View commit details
    Browse the repository at this point in the history

  2. Start local work generation along with work peer requests

    @guilhermelawless
    guilhermelawless committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    bdcc24d View commit details
    Browse the repository at this point in the history

  3. Work cancel done in a new socket

    @guilhermelawless
    guilhermelawless committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    2dc73b4 View commit details
    Browse the repository at this point in the history

  4. Log if work generation cannot be performed

    @guilhermelawless
    guilhermelawless committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    8e289ca View commit details
    Browse the repository at this point in the history

  5. Making sure stop is only called once

    @guilhermelawless
    guilhermelawless committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    dabbe5c View commit details
    Browse the repository at this point in the history

  6. Simplifying connection handling

    @guilhermelawless
    guilhermelawless committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    4efe2eb View commit details
    Browse the repository at this point in the history

  7. Fix bad address from unordered map

    @guilhermelawless
    guilhermelawless committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    6658997 View commit details
    Browse the repository at this point in the history

  8. Stop on destructor

    @guilhermelawless
    guilhermelawless committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    0d0b3f5 View commit details
    Browse the repository at this point in the history

  9. Correctly stopping work generation on node stop

    @guilhermelawless
    guilhermelawless committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    453fb89 View commit details
    Browse the repository at this point in the history

  10. Use atomic<bool> and exchange

    @guilhermelawless
    guilhermelawless committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    fb06b76 View commit details
    Browse the repository at this point in the history

  11. node.work is not stopped on node.stop due to testing setup

    @guilhermelawless
    guilhermelawless committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    e97006e View commit details
    Browse the repository at this point in the history

Commits on Aug 23, 2019

  1. Local work generation is now only used in case peers are unresponsive 

    This change enhances the previous behavior. Local work generation is only used after all peers are unresponsive.

A flag is set in the node (unresponsive_work_peers) so that for the next distributed work, local generation will start immediately. Work peer requests are still sent, and as soon as one replies with valid work, local generation is delayed again, until all are unresponsive, and so on.

This is more of a fallback mechanism when all peers are failing, as the previous behavior would always wait for timeouts on peers (which can be long, 2 minutes here). The only case not handled for simplicity is when multiple work is queued, and the first one has unresponsive peers. In this case, the currently queued work requests will not start work generation immediately, only for the next queued distributed work.
    @guilhermelawless
    guilhermelawless committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    0c5b8e9 View commit details
    Browse the repository at this point in the history

  2. Also start local generation immediately if there are no work peers

    @guilhermelawless
    guilhermelawless committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    dcdfa2e View commit details
    Browse the repository at this point in the history

  3. Robustify

    @guilhermelawless
    guilhermelawless committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    0985b1c View commit details
    Browse the repository at this point in the history

  4. Unbreak tests

    @guilhermelawless
    guilhermelawless committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    b4d04e7 View commit details
    Browse the repository at this point in the history

  5. No need to wrap in node background

    @guilhermelawless
    guilhermelawless committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    56665bd View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into distibuted-work-fixes

    @guilhermelawless
    guilhermelawless committed Aug 23, 2019
    Configuration menu
    Copy the full SHA
    77b5689 View commit details
    Browse the repository at this point in the history