-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TOML config file support and migration #2221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cryptocode
added
documentation
This item indicates the need for or supplies updated or expanded documentation
beta testing wanted
toml
TOML related change
labels
Aug 16, 2019
wezrule
reviewed
Aug 17, 2019
wezrule
reviewed
Aug 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have done some testing on Windows with node/rpc configs, working great. Also ran cppcheck
which didn't find any warnings.
cryptocode
force-pushed
the
feature/toml
branch
from
August 19, 2019 13:33
88976e2
to
c63a3dd
Compare
cryptocode
force-pushed
the
feature/toml
branch
from
August 20, 2019 08:34
c63a3dd
to
21bb7e1
Compare
wezrule
approved these changes
Aug 21, 2019
zhyatt
requested review from
guilhermelawless
and removed request for
SergiySW
August 23, 2019 16:47
guilhermelawless
approved these changes
Aug 23, 2019
zhyatt
added
major
This item indicates the need for or supplies a major or notable change
and removed
beta testing wanted
labels
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
This item indicates the need for or supplies updated or expanded documentation
major
This item indicates the need for or supplies a major or notable change
toml
TOML related change
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds TOML support and migration of json config files on startup.
User facing changes:
--config
option, which can be repeated multiple times. These options will take precedence over any entries in the config file (which doesn't need to exist). Example:nano_node --daemon --config rpc.enable=true
config-node.toml
file can be used for both the node and the Qt wallet.--generate_config node|rpc
. The user can use these directly, or pick what they need. Comments with schema information is added to facilitate future tooling/editor support. Sample output: https://gist.github.com/cryptocode/4d05774390518ddaadab61f838288d20enable
under their respective config sections, to keep it consistent with other sections. The HTTP callback settings are grouped under a separate section.Developer facing changes:
Should be ready for review, though some updates will be added:
We might extract more settings into separate toml files in upcoming PRs - the work generation part has been discussed, details remain.