Remove querying pending confirmation height in various operations #2156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wezrule
added
universe
cryptocode
approved these changes
Jul 16, 2019
cryptocode
added
the
documentation
wezrule
added
awaiting response
and removed
universe
|
As discussed in our meeting we are holding off on merging this until closer to RC period. |
argakiig
approved these changes
Jul 18, 2019
cryptocode
approved these changes
Sep 14, 2019
argakiig
approved these changes
Sep 20, 2019
SergiySW
approved these changes
Sep 28, 2019
zhyatt
added
rpc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the development of the confirmation height processor (at that time) it was quite slow, so anyone calling
block_confirmwould have seen inconsistent results fromblock_infowhich would state that a block was unconfirmed. It is decided that any block pending confirmation or currently undergoing it would show up as confirmed as well. But this leads to other inconsistencies as blocks below it may not be seen as confirmed but this was seen as acceptable at the time. Now after many performance improvements since then, and that in v19 most nodes upgrading to v20 will have synced cemented counts anyway this restriction has been removed so a block will only show as confirmed in RPCs if all blocks below it are also marked as confirmed.