Improve stacktrace output during release_assert #2142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a stress test @Srayman's node crashed, it hit a
release_assert
inpending_put
but no other useful information was given. The abort signal handler is hit but no stacktraces generated.From:
https://www.boost.org/doc/libs/1_67_0/doc/html/stacktrace/getting_started.html#stacktrace.getting_started.handle_terminates_aborts_and_seg
Windows is one of these platforms, and while we cannot create the stacktrace dump during an unexpected crash (in the signal handler) we can output the stacktrace to a file before we
abort
ourselves inrelease_assert
which will help in these cases.All platforms will also now output the stacktrace to
cerr
.Also moved linux specific code for crash dumps to the platform specific directory.
Tested on Ubuntu/Windows