Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info : fix heap-buffer overflow in read_taskinfo() #1963

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ParkSeungHyeok
Copy link
Contributor

It fixes a heap-buffer overflow issue caused by data in taskinfo:tids. The root cause was insufficient exception handling for tid values.

This patch added exception handling to manage any value written to tids_str

  • The exception handling ensures that:
    1. tids_str has the same number of values as info->nr_tid.
    2. Each tid value in tids_str is properly separated by a comma.

Fixed: #938

It fixes a heap-buffer overflow issue caused by data in
taskinfo:tids. The root cause was insufficient exception
handling for tid values.

Added exception handling to manage any value written to tids_str

Fixed: namhyung#938

Signed-off-by: Seunghyeok Park <tmdgur1324@naver.com>
Copy link
Owner

@namhyung namhyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The unittest code is in the tests/unittest.[ch] files. But I'm not sure if it's easy to make unittests for the info code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

heap-buffer overflow in read_taskinfo()
2 participants