feat: allow pydantic v2 usage #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: start migration to pydantic v2 * update tests for pydantic v2
nadobando
approved these changes
Jul 15, 2024
| @@ -100,7 +100,7 @@ version = "0.2.1" | |||
| [tool.poetry.dependencies] | |||
| aioarango = "^1.0.0" | |||
| indexed = "^1.3.0" | |||
| pydantic = "==1.10.12" | |||
| pydantic = ">=1.10.17" | |||
There was a problem hiding this comment.
maybe we can already set this to
Suggested change
| pydantic = ">=1.10.17" | |
| pydantic = "<2" |
There was a problem hiding this comment.
The documentation claims that the v1 modules were not added till 1.10.17. Another option is to update the imports to something like this:
try:
from pydantic.v1.fields import ModelField
except ImportError:
from pydantic.fields import ModelField 
|
I'm a bit confused by the CI checks. They ran locally fine. I will take a look at the errors and update as needed. |
|
I see my issue. The CI/CD uses 3.9 and I was using 3.11 locally. |
- Fix issues raised in ci/cd for nadobando#15 that came from testing with python 3.11 locally instead of python 3.9
|
All tests passed. There is something wrong with the tokens. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followed https://docs.pydantic.dev/latest/migration/#using-pydantic-v1-features-in-a-v1v2-environment
Note that current documentation references a CONTRIBUTING.md that does not exist. The GitHub Pages site encourages reaching out for instructions on contributing, but no contact information is listed. Please feel free to comment on any changes needed.