Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Running Root Migrations Before Module Migrations #1919

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

alissn
Copy link
Contributor

@alissn alissn commented Aug 12, 2024

Hi,

While testing the module:migrate-fresh command, I discovered that root migrations were not being executed before the module migrations.

This issue occurs because, in the Laravel framework's migrate command, the default migration paths are merged when the method is called, but they are not registered by default. You can see the relevant code here: Laravel Framework Migration Command.

return array_merge(
    $this->migrator->paths(), [$this->getMigrationPath()]
);

This pull request addresses and fixes this issue, ensuring that root migrations are executed before module migrations.

@dcblogdev dcblogdev merged commit 7079478 into nWidart:master Aug 12, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants