Optimize FileRepository #1898
Merged
Optimize FileRepository #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update DocBlock (methods documentation comments) Rearranged methods based on operations and relativity. Update: all() -> all(?bool $enabled = null) Add the ability to filter modules by status Update: count() -> count(?bool $enabled = null) Add the ability to filter modules by status Add: collect(?bool $status = true): Collection Simplified methods name: - addLocation() -> add_path() - getPaths() -> paths() - getScanPaths() -> scanPaths() - createModule() -> module() - getCached() -> cached() - getByStatus() - > status() - allEnabled() -> all(true) - allDisabled() -> all(false) - getOrdered() -> ordered() - getPath() -> path() - getModulePath() -> modulePath() - getUsedStoragePath() -> usedStoragePath() - setUsed() -> use() - getUsedNow() -> used() - getFiles() -> files() - getAssetsPath() -> assetsPath() - isEnabled() ->enabled() - isDisabled() -> disabled() - getStubPath() -> stubPath()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update DocBlock (methods documentation comments)
Rearranged methods based on operations and relativity.
Update: all() -> all(?bool $enabled = null)
Add the ability to filter modules by status
Update: count() -> count(?bool $enabled = null)
Add the ability to filter modules by status
Add: collect(?bool $status = true): Collection
Simplified methods name:
All existing methods are intact.