Turn off eslint no-use-before-define #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 68dc3bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 36 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
enisdenjo
changed the base branch from
main
to
saihaj/engine-agnostic-non-breaking
dimaMachina
approved these changes
Sep 13, 2022
diff --git a/website/algolia-lockfile.json b/website/algolia-lockfile.json
index 9e359f52..d5281857 100644
--- a/website/algolia-lockfile.json
+++ b/website/algolia-lockfile.json
@@ -361,11 +361,6 @@
"children": [],
"title": "`onSchemaChange(api)`",
"anchor": "onschemachangeapi"
- },
- {
- "children": [],
- "title": "`onResolverCalled(api)`",
- "anchor": "onresolvercalledapi"
}
],
"title": "`onPluginInit(api)`", |
❌ Benchmark FailedFailed assertions detected: some GraphQL operations included in the loadtest are failing.
|
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@envelop/core |
3.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/apollo-datasources |
2.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/apollo-federation |
3.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/apollo-server-errors |
4.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/apollo-tracing |
4.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/auth0 |
4.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/dataloader |
4.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/depth-limit |
2.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/disable-introspection |
4.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/execute-subscription-event |
3.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/extended-validation |
2.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/filter-operation-type |
4.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/fragment-arguments |
4.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/generic-auth |
5.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/graphql-jit |
5.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/graphql-middleware |
4.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/graphql-modules |
4.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/immediate-introspection |
1.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/live-query |
5.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/newrelic |
5.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/on-resolve |
2.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/opentelemetry |
4.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/operation-field-permissions |
4.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/parser-cache |
5.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/persisted-operations |
5.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/preload-assets |
4.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/prometheus |
7.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/rate-limiter |
4.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/resource-limitations |
3.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/response-cache |
4.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/response-cache-redis |
2.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/sentry |
4.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/statsd |
3.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/validation-cache |
5.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/testing |
5.0.0-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
@envelop/types |
2.4.1-alpha-20220913094304-9b2d5c2a |
npm ↗︎ unpkg ↗︎ |
saihaj
added a commit
that referenced
this pull request
Oct 12, 2022
* feat: non-breaking GraphQL Engine * feat: make envelop take in engine functions * structural typings * remove grapqhl as peer dep from types pkg * make core more agnostic * chore(dependencies): updated changesets for modified dependencies * remove traced schema * remove traced orchestrator * make plugin agnostic * drop EnvelopError * remove more graphql import * Drop useTiming * make core completely free of graphql-js * add eslint rule * eslint disallow in types too * more agnostic packages * remove introspection util * chore(dependencies): updated changesets for modified dependencies * prettier * TEMP: make bot calm down * update all docs * test matrix for core * experimenting traced schema (#1501) * experimenting traced schema * Fix * remove comment * do optional chaining since we are not strongly typing * document * cleanup Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com> * feat: drop node 12 (#1505) * feat: remove `enableIf` utility (#1504) * feat: remove enableIf utility * make types happpy * make types happy * add changeset * feat: remove async schema plugin and rename lazy loaded schema plugin (#1506) * remove useAsyncSchema * rename to useSchemaByContext * add eslint rule (#1509) * feat: `@envelop/on-resolve` plugin for hooking into schema resolvers (#1500) * on resolve plugin * changeset * no more onResolverCalled * unused import * args is a record * integrate and useOnResolve * resolversHooksSymbol does not exist * plugincontext for OnPluginInit * on-resolve uses addPlugin * onresolvercalled is no more * refactor for new on-resolve * fix open-telemetry tests * fix newrelic * opentelemetry graphql as peer dep * tests * addPlugin doesnt need to be used * reorder * respects onPluginInit context * drop unused import * fixes false positive eslint warnings Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com> * docs: order of plugins matter (#1513) * feat: remove handler for validation and parse errors (#1510) * feat: remove hanlder for validation and parse errors * tests * make it work * Add docs * Fix serialization issue * Go * .. * update docs * update test * make it work * feat: add originalError in dev mode (#1514) * remove Fn appendix * name graphql error * make ts happy * make toJSON required Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com> Co-authored-by: Laurin Quast <laurinquast@googlemail.com> * add changeset * Update .changeset/nervous-seas-own.md * Update .changeset/rude-cats-peel.md * no-use-before-define (#1522) * feat: trigger on context, validate and parse errors (#1511) * feat: trigger on context, validate and parse errors * trying * make it work * pass in phase * add phase details * feedback * docs: migration guide (#1520) * docs: migration guide * remove slashes * Update website/docs/guides/migrating-from-v2-to-v3.mdx Co-authored-by: Denis Badurina <badurinadenis@gmail.com> * feedback * document removing of orchestrated tracer * more feedback * update docs * update examples * async schema example Co-authored-by: Denis Badurina <badurinadenis@gmail.com> * Add redirects * remove deafult skip error from sentry plugin * export masked error plugin * sentry plugin default skip GraphQLError * sentry: og error is not graphql error then send to sentry * doc: drop introspection utils * should fix ts issues on v15 * test: stack error we should not match the error name since it can be different across impl * feat: use engine plugin (#1535) * feat: use engine plugin * remove assertion * make useEngine plugin the only way to pass engine functions (#1536) * make useEngine plugin the only way to pass engine fns * update types * update docs * Update packages/plugins/apollo-datasources/README.md Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com> * prettier: Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com> Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com> * fix * versioned docs with v3 default * fix build * fix * feat this is cool * docs reword schema tracing * docs add graphql error example * docs restructuring, fix typos * chore remove autogenerated changeset * cleanup changeset * docs sycn patch Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Arda TANRIKULU <ardatanrikulu@gmail.com> Co-authored-by: Denis Badurina <denis@domonda.com> Co-authored-by: Dimitri POSTOLOV <dmytropostolov@gmail.com> Co-authored-by: Laurin Quast <laurinquast@googlemail.com> Co-authored-by: Denis Badurina <badurinadenis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eslint's
no-use-before-defineraises false positives for types:Since TypeScript itself disallows usage of variables before declaration, it makes sense to disable all matching eslint rules.
In essence:
{ "no-use-before-define": "off", "typescript-eslint/no-use-before-define": "off" }