Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop official Node.js 12 support #1417

Closed
wants to merge 6 commits into from
Closed

Conversation

n1ru4l
Copy link
Owner

@n1ru4l n1ru4l commented Jun 9, 2022

Node.js reached end of life a while ago. While we still technically support it we should still move on.

https://endoflife.date/nodejs

image

image

@vercel
Copy link

vercel bot commented Jun 9, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
envelop ✅ Ready (Inspect) Visit Preview Jun 20, 2022 at 7:12AM (UTC)

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jun 9, 2022

The latest changes of this PR are available as alpha in npm (based on the declared changesets):

@envelop/core@3.0.0-alpha-d0d0776.0
@envelop/apollo-datasources@2.0.0-alpha-d0d0776.0
@envelop/apollo-federation@3.0.0-alpha-d0d0776.0
@envelop/apollo-server-errors@4.0.0-alpha-d0d0776.0
@envelop/apollo-tracing@4.0.0-alpha-d0d0776.0
@envelop/auth0@4.0.0-alpha-d0d0776.0
@envelop/dataloader@4.0.0-alpha-d0d0776.0
@envelop/depth-limit@2.0.0-alpha-d0d0776.0
@envelop/disable-introspection@4.0.0-alpha-d0d0776.0
@envelop/execute-subscription-event@3.0.0-alpha-d0d0776.0
@envelop/extended-validation@2.0.0-alpha-d0d0776.0
@envelop/filter-operation-type@4.0.0-alpha-d0d0776.0
@envelop/fragment-arguments@4.0.0-alpha-d0d0776.0
@envelop/generic-auth@5.0.0-alpha-d0d0776.0
@envelop/graphql-jit@5.0.0-alpha-d0d0776.0
@envelop/graphql-middleware@4.0.0-alpha-d0d0776.0
@envelop/graphql-modules@4.0.0-alpha-d0d0776.0
@envelop/live-query@4.0.0-alpha-d0d0776.0
@envelop/newrelic@5.0.0-alpha-d0d0776.0
@envelop/opentelemetry@4.0.0-alpha-d0d0776.0
@envelop/operation-field-permissions@4.0.0-alpha-d0d0776.0
@envelop/parser-cache@5.0.0-alpha-d0d0776.0
@envelop/persisted-operations@5.0.0-alpha-d0d0776.0
@envelop/preload-assets@4.0.0-alpha-d0d0776.0
@envelop/prometheus@7.0.0-alpha-d0d0776.0
@envelop/rate-limiter@4.0.0-alpha-d0d0776.0
@envelop/resource-limitations@3.0.0-alpha-d0d0776.0
@envelop/response-cache@3.0.0-alpha-d0d0776.0
@envelop/response-cache-redis@1.0.0-alpha-d0d0776.0
@envelop/sentry@4.0.0-alpha-d0d0776.0
@envelop/statsd@3.0.0-alpha-d0d0776.0
@envelop/validation-cache@5.0.0-alpha-d0d0776.0
@envelop/testing@5.0.0-alpha-d0d0776.0
@envelop/types@3.0.0-alpha-d0d0776.0

@theguild-bot
Copy link
Collaborator

theguild-bot commented Jun 9, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.............................................: 100.00% ✓ 590548      ✗ 0     
     data_received......................................: 2.3 GB  15 MB/s
     data_sent..........................................: 129 MB  857 kB/s
     envelop_init.......................................: avg=608ns    min=99ns    med=300ns   max=5.72ms  p(90)=999ns   p(95)=1.9µs  
     ✓ { mode:envelop-cache-jit }.......................: avg=423ns    min=100ns   med=300ns   max=2.07ms  p(90)=599ns   p(95)=700ns  
     ✓ { mode:envelop-just-cache }......................: avg=368ns    min=99ns    med=300ns   max=410.8µs p(90)=400ns   p(95)=599ns  
     ✓ { mode:graphql-js }..............................: avg=526ns    min=99ns    med=299ns   max=106µs   p(90)=2µs     p(95)=2.29µs 
     ✓ { mode:prom-tracing }............................: avg=2.93µs   min=1.19µs  med=1.79µs  max=5.72ms  p(90)=2.99µs  p(95)=7.79µs 
     envelop_total......................................: avg=202.24µs min=0s      med=21.8µs  max=15.51ms p(90)=452.7µs p(95)=1.38ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=21.27µs  min=14.39µs med=19.4µs  max=11.07ms p(90)=26.4µs  p(95)=29.3µs 
     ✓ { mode:envelop-just-cache }......................: avg=171.65µs min=140.1µs med=164.1µs max=13.07ms p(90)=183.7µs p(95)=196.4µs
     ✓ { mode:graphql-js }..............................: avg=496.27µs min=383.6µs med=446µs   max=11.44ms p(90)=490.6µs p(95)=548.8µs
     ✓ { mode:prom-tracing }............................: avg=1.59ms   min=1.32ms  med=1.41ms  max=15.51ms p(90)=1.75ms  p(95)=2.82ms 
     event_loop_lag.....................................: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-cache-jit }.......................: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:envelop-just-cache }......................: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:graphql-js }..............................: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     ✓ { mode:prom-tracing }............................: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     graphql_context....................................: avg=3.6µs    min=1.59µs  med=2.7µs   max=3.99ms  p(90)=5.89µs  p(95)=6.8µs  
     ✓ { mode:envelop-cache-jit }.......................: avg=2.73µs   min=1.59µs  med=2.39µs  max=3.03ms  p(90)=3.6µs   p(95)=4.3µs  
     ✓ { mode:envelop-just-cache }......................: avg=2.91µs   min=1.79µs  med=2.6µs   max=1.43ms  p(90)=3.59µs  p(95)=4.09µs 
     ✓ { mode:graphql-js }..............................: avg=5.52µs   min=3.3µs   med=4.6µs   max=3.99ms  p(90)=7.89µs  p(95)=9.2µs  
     ✓ { mode:prom-tracing }............................: avg=7.04µs   min=5.39µs  med=6.5µs   max=591.9µs p(90)=7.9µs   p(95)=9.2µs  
     graphql_execute....................................: avg=204.57µs min=7.8µs   med=147.1µs max=15.32ms p(90)=186.1µs p(95)=1.33ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=11.17µs  min=7.8µs   med=10.2µs  max=9.53ms  p(90)=12.8µs  p(95)=14.09µs
     ✓ { mode:envelop-just-cache }......................: avg=161.46µs min=132.5µs med=154.8µs max=13.06ms p(90)=171.6µs p(95)=182.4µs
     ✓ { mode:graphql-js }..............................: avg=187.4µs  min=138.8µs med=165.1µs max=10.97ms p(90)=178.7µs p(95)=191.8µs
     ✓ { mode:prom-tracing }............................: avg=1.52ms   min=1.26ms  med=1.35ms  max=15.32ms p(90)=1.66ms  p(95)=2.75ms 
     graphql_parse......................................: avg=10.17µs  min=3.09µs  med=5.19µs  max=8.76ms  p(90)=15.99µs p(95)=46.7µs 
     ✓ { mode:envelop-cache-jit }.......................: avg=5.3µs    min=3.09µs  med=4.89µs  max=744.7µs p(90)=7.09µs  p(95)=8µs    
     ✓ { mode:envelop-just-cache }......................: avg=5.52µs   min=3.4µs   med=4.8µs   max=8.76ms  p(90)=6.4µs   p(95)=7.79µs 
     ✓ { mode:graphql-js }..............................: avg=13.19µs  min=7.79µs  med=10.69µs max=6.21ms  p(90)=16.9µs  p(95)=19.29µs
     ✓ { mode:prom-tracing }............................: avg=51.39µs  min=40.2µs  med=48.19µs max=3.31ms  p(90)=56.9µs  p(95)=63.2µs 
     graphql_validate...................................: avg=52.4µs   min=799ns   med=1.5µs   max=11.1ms  p(90)=262.7µs p(95)=269.2µs
     ✓ { mode:envelop-cache-jit }.......................: avg=1.63µs   min=899ns   med=1.5µs   max=1.21ms  p(90)=2µs     p(95)=2.19µs 
     ✓ { mode:envelop-just-cache }......................: avg=1.38µs   min=799ns   med=1.19µs  max=1.55ms  p(90)=1.6µs   p(95)=1.89µs 
     ✓ { mode:graphql-js }..............................: avg=289.62µs min=227.4µs med=263.9µs max=11.1ms  p(90)=286.6µs p(95)=317.2µs
     ✓ { mode:prom-tracing }............................: avg=5.9µs    min=4.19µs  med=5.2µs   max=2.55ms  p(90)=6.4µs   p(95)=8.39µs 
     http_req_blocked...................................: avg=3.68µs   min=700ns   med=1.3µs   max=12.69ms p(90)=2.2µs   p(95)=2.8µs  
     http_req_connecting................................: avg=496ns    min=0s      med=0s      max=11.39ms p(90)=0s      p(95)=0s     
     http_req_duration..................................: avg=4.64ms   min=210.8µs med=2.99ms  max=81.74ms p(90)=10.8ms  p(95)=15.34ms
       { expected_response:true }.......................: avg=4.64ms   min=210.8µs med=2.99ms  max=81.74ms p(90)=10.8ms  p(95)=15.34ms
     ✓ { mode:envelop-cache-and-no-internal-tracing }...: avg=3.6ms    min=318.7µs med=2.86ms  max=43.66ms p(90)=5.96ms  p(95)=7.66ms 
     ✓ { mode:envelop-cache-jit }.......................: avg=2.8ms    min=210.8µs med=2.09ms  max=29.61ms p(90)=5.62ms  p(95)=9.78ms 
     ✓ { mode:envelop-just-cache }......................: avg=3.65ms   min=337.1µs med=2.88ms  max=34.94ms p(90)=6.31ms  p(95)=8.55ms 
     ✓ { mode:graphql-js }..............................: avg=7.33ms   min=745.8µs med=5.69ms  max=66.66ms p(90)=11.88ms p(95)=13.49ms
     ✓ { mode:prom-tracing }............................: avg=17.93ms  min=1.88ms  med=15.81ms max=81.74ms p(90)=29.95ms p(95)=32.06ms
     http_req_failed....................................: 0.00%   ✓ 0           ✗ 295274
     http_req_receiving.................................: avg=55.67µs  min=12.2µs  med=22.1µs  max=24.53ms p(90)=35µs    p(95)=43.7µs 
     http_req_sending...................................: avg=40.34µs  min=5µs     med=8.1µs   max=28.49ms p(90)=15µs    p(95)=23.7µs 
     http_req_tls_handshaking...........................: avg=0s       min=0s      med=0s      max=0s      p(90)=0s      p(95)=0s     
     http_req_waiting...................................: avg=4.55ms   min=169.6µs med=2.93ms  max=81.65ms p(90)=10.47ms p(95)=15.25ms
     http_reqs..........................................: 295274  1968.349993/s
     iteration_duration.................................: avg=5.07ms   min=442.2µs med=3.33ms  max=82.13ms p(90)=11.52ms p(95)=15.76ms
     iterations.........................................: 295274  1968.349993/s
     vus................................................: 1       min=1         max=11  
     vus_max............................................: 20      min=20        max=20  

@n1ru4l
Copy link
Owner Author

n1ru4l commented Jun 10, 2022

Currently blocked by kamilkisiela/bob#42

@n1ru4l n1ru4l force-pushed the feat-drop-node-12-support branch from d617af0 to f853692 Compare June 20, 2022 07:10
@n1ru4l n1ru4l mentioned this pull request Jul 4, 2022
@n1ru4l n1ru4l closed this Jul 4, 2022
@saihaj saihaj deleted the feat-drop-node-12-support branch July 4, 2022 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants