fix: updates PictureFrame sequencing to prevent unfortunate conflicts #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n10v
approved these changes
Oct 13, 2021
There was a problem hiding this comment.
Hi @tillt,
thanks for your issue and submitted solution! Your change makes complete sense to me and I merge it.
In id3v2 docs it says that There may be several pictures attached to one file but only one with the same content descriptor. But what is content descriptor for APIC? There is no such property in it and no explanation in specs. And it also doesn't make sense to me to keep same APICs only by description. Considering picture type and description makes more sense.
Even though the change is good, it breaks behaviour, so I will release a new major version with this change.
| @@ -22,7 +23,7 @@ type PictureFrame struct { | |||
| } | |||
|
|
|||
| func (pf PictureFrame) UniqueIdentifier() string { | |||
| return pf.Description | |||
| return fmt.Sprintf("%02X%s", pf.PictureType, pf.Description) | |||
There was a problem hiding this comment.
Nice idea to use 2 bytes for picture type in unique identifier 👍
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the source file contains multiple
APICframes, with equalDescriptions, we will only use the first one. This is not really what we want. We want to use the first one matching thisDescriptionandPictureType.This patch ensures that
APICframes of differentPictureTypewill be considered unique even if theDescriptionwas not.Updates sequencing tests accordingly. Seems I had to get a bit more verbose in the test coverage.