- CS104 connection: Fix use-after-free in handleConnection() (see #61) #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If user calls CS104_Connection_destroy() in connectionHandler() on CONNECTION_CLOSED event -
two memory errors will occur in handleConnection() because self is not valid anymore
(after returning from connectionHandler() which called CS104_Connection_destroy() before):
(cs104_connection.c:817) Socket_destroy(self->socket);
(cs104_connection.c:821) self->running = false;
So, it's necessary to call connectionHandler() with CONNECTION_CLOSED event right before exiting
from handleConnection().
Fixes #61