🐛 fix double free of tlsSocket #159
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a double free of tlsSocket, if there was a successfull connection once, then the server goes away. The next time the connection will fail in socket connect and therefore will not overwrite self->tlsSocket and we try to free the already freed tlsSocket from the previous connection again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a double free of tlsSocket in a cs104 connection.
Reproduce double free:
-> self->tlsSocket is allocated
-> connection is closed
-> self->tlsSocket is freed, but the pointer is not NULLed
-> socket connect fails
-> self->tlsSocket untouched
-> self->tlsSocket freed again
This fix simple set tlsSocket to NULL once freed.