Integration of android CustomTabsService #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
Android WebView does not support downloading or reading PDF-files based on the missing integration.
Change is required to allow a full functional browser providing e. g. PDF-Download function.
Description
This change integrates the android CustomTabsService as an optional in-app-browser functionality.
In case the used platform dos not provide any installed application packages, which can handle view-intents, the default android WebView will be used, based on the original cordova-plugin-inappbrowser.
Testing
Tested on android device and android emulator using VS Code and Android Studio for developing.