Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow base=None to disable log formatter in Continuous.label #3087

Merged
merged 1 commit into from
Oct 16, 2022

Conversation

mwaskom
Copy link
Owner

@mwaskom mwaskom commented Oct 16, 2022

Simple change to make it possible not to use log formatted (scientific notation) ticks with a log transform:

(
    so.Plot(diamonds, "carat", "price")
    .add(so.Dots())
    .scale(y=so.Continuous(trans="log").tick(at=[300, 1000, 3000, 10000]).label(base=None))
)

@codecov
Copy link

codecov bot commented Oct 16, 2022

Codecov Report

Merging #3087 (7b7ac00) into master (a02b6bf) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3087   +/-   ##
=======================================
  Coverage   98.39%   98.39%           
=======================================
  Files          74       74           
  Lines       23768    23776    +8     
=======================================
+ Hits        23387    23395    +8     
  Misses        381      381           
Impacted Files Coverage Δ
seaborn/_core/scales.py 89.76% <100.00%> (+0.02%) ⬆️
tests/_core/test_scales.py 100.00% <100.00%> (ø)

@mwaskom mwaskom merged commit a42d62d into master Oct 16, 2022
@mwaskom mwaskom deleted the scale/log_labels branch October 16, 2022 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant