Add uri=True in mvt/ios/modules/base.py
#442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msx98
force-pushed
the
bugfix/db-open-uri-py311
branch
from
e5290df
to
c4d3b4b
Compare
roaree
approved these changes
Dec 28, 2023
This was referenced Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #434 - tested on Ubuntu 22.04, Python 3.11.6
uriwas added in Python 3.4 and it looks like this repo already requires >=3.8I did not add 3.11 to
.github/workflows/python-package.ymlbecause it causes the CI to fail on safety (outdated pip - requires >=23.3), but unit tests seem to pass on this version