Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker tweaks #424

Merged
merged 1 commit into from
Nov 27, 2023
Merged

docker tweaks #424

merged 1 commit into from
Nov 27, 2023

Conversation

r-tx
Copy link
Contributor

@r-tx r-tx commented Nov 23, 2023

  • Install MVT from github rather than PiPY
  • Install latest abe

roaree
roaree approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@roaree roaree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Dockerfile
@@ -57,12 +57,12 @@ RUN git clone https://github.com/libimobiledevice/libplist \

# Installing MVT
# --------------
RUN pip3 install mvt
RUN pip3 install git+https://github.com/mvt-project/mvt.git@main
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally I think we should be copying in from whatever's in the locally checked out directory, but this seems like an improvement regardless

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could update it for that, though I wonder would it make more sense for you to put it up on docker hub? It'd cut down on the steps a little to get the container up and running.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be in favour of us publishing an official docker image

@roaree roaree merged commit acc9503 into mvt-project:main Nov 27, 2023
1 of 4 checks passed
@r-tx r-tx deleted the docker_tweaks branch January 15, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roaree roaree roaree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@r-tx @roaree