Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source code fix for modern version of Python and scikit-learn #108

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

vincenzomanzoni
Copy link

Dear project maintainers,

crab is a very good starting point for machine learning researchers that would like to implement recommender system in Python. However, there are a couple of issues in the source code that do not let the code working out-of-the-box.

There are people already discussing about these issues.

I fixed the code in order to work with current versions of Python and scikit-learn. I tested on my machine (Mac OSX El Capitan, 10.11.4) with Python 2.7.10 and it works.

I hope you are going to accept this pull request.

Bests,

Vincenzo

…eptember 2011). Changed self._set_params to self.set_params.
Aims of the fork; reference to the original GitHub project.
Minor change.
@Hiyorimi
Copy link

Hiyorimi commented Jun 16, 2016

I believe the project is no longer maintained, so you fork could be a great starting point for updating it.

According to pull requests, last PR was closed 3 years ago.

@vincenzomanzoni
Copy link
Author

Thanks Hiyorimi. Unfortunately, I am not in the recommendation system area,
I just needed for a specific case. Bests, Vincenzo

On Thu, Jun 16, 2016 at 11:00 PM, Hiyorimi notifications@github.com wrote:

I believe the project is no longer maintained, so you fork could be a
great starting point for updating it.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#108 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/AK9djVV_-8M-HS0dO1CwiF-nVWYPfbgxks5qMblSgaJpZM4IuUxh
.

Vincenzo Manzoni

Head | Control and Analytics on Industrial Processes | Tenaris
President | Information Engineering Committee | Ordine degli Ingegneri di
Bergamo

me@vincenzomanzoni.com | vincenzomanzoni.com |
linkedin.com/in/vincenzomanzoni

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants