Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update classes.py in knn #103

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions scikits/crab/recommenders/knn/classes.py
Original file line number Diff line number Diff line change
Expand Up @@ -532,12 +532,15 @@ def estimate_preference(self, user_id, item_id, **params):

prefs = np.array([self.model.preference_value(to_user_id, item_id)
for to_user_id in nearest_neighbors])

prefs = prefs[~np.isnan(prefs)]
similarities = similarities[~np.isnan(prefs)]

prefs_sim = np.sum(prefs[~np.isnan(similarities)] *
similarities[~np.isnan(similarities)])

temp_prefs = [~np.isnan(prefs)]
temp_similarities = [~np.isnan(similarities)]
noNaN_indices = np.logical_and(temp_prefs, temp_similarities)

prefs_sim = np.sum(prefs[noNaN_indices[0] == True] *
similarities[noNaN_indices[0] == True])

similarities = similarities[~np.isnan(similarities)]
total_similarity = np.sum(similarities)

#Throw out the estimate if it was based on no data points,
Expand Down