Skip to content

Commit

Permalink
W-14453564: Change groupId of artifacts that end up in the lib/boot f…
Browse files Browse the repository at this point in the history
…older (#12987)
  • Loading branch information
elrodro83 authored Dec 4, 2023
1 parent 46c35db commit ef9680b
Show file tree
Hide file tree
Showing 18 changed files with 29 additions and 25 deletions.
2 changes: 1 addition & 1 deletion core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-logging</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
Expand Down
4 changes: 2 additions & 2 deletions modules/all-modules/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-logging</artifactId>
<version>${project.version}</version>
</dependency>
Expand Down Expand Up @@ -127,7 +127,7 @@
</dependency>

<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-jpms-utils</artifactId>
<version>${project.version}</version>
</dependency>
Expand Down
7 changes: 4 additions & 3 deletions modules/boot-api/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<version>4.7.0-SNAPSHOT</version>
</parent>

<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-boot-api</artifactId>
<name>Mule Boot API</name>
<packaging>jar</packaging>
Expand All @@ -26,21 +27,21 @@

<!-- Needed by the MuleLog4jConfigurer -->
<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-log4j-boot-configurator</artifactId>
<version>${project.version}</version>
</dependency>

<!-- Needed by the BootModuleLayerValidationBootstrapConfigurer and for creating the container ClassLoader -->
<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-jpms-utils</artifactId>
<version>${project.version}</version>
</dependency>

<!-- Needed by the SLF4JBridgeHandlerBootstrapConfigurer, but also to make the logging modules available from the boot layer -->
<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-logging</artifactId>
<version>${project.version}</version>
</dependency>
Expand Down
2 changes: 1 addition & 1 deletion modules/container/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-jpms-utils</artifactId>
<version>${project.version}</version>
</dependency>
Expand Down
2 changes: 1 addition & 1 deletion modules/core-components/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
<version>${muleExtensionsApiVersion}</version>
</dependency>
<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-logging</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
Expand Down
2 changes: 1 addition & 1 deletion modules/extensions-xml-support/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-logging</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
Expand Down
1 change: 1 addition & 0 deletions modules/jpms-utils/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
</parent>
<modelVersion>4.0.0</modelVersion>

<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-jpms-utils</artifactId>
<name>Mule Java JPMS utilities</name>
<description>This module provides JMPS utilities for use within the Mule Runtime.</description>
Expand Down
4 changes: 2 additions & 2 deletions modules/launcher/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-logging</artifactId>
<version>${project.version}</version>
</dependency>
Expand Down Expand Up @@ -63,7 +63,7 @@
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-boot-api</artifactId>
<version>${project.version}</version>
</dependency>
Expand Down
3 changes: 2 additions & 1 deletion modules/log4j-boot-configurator/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<artifactId>mule-modules</artifactId>
<version>4.7.0-SNAPSHOT</version>
</parent>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-log4j-boot-configurator</artifactId>
<packaging>jar</packaging>
<name>Mule Log4j Boot Configurator Module</name>
Expand All @@ -21,7 +22,7 @@

<dependencies>
<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-logging</artifactId>
<version>${project.version}</version>
</dependency>
Expand Down
4 changes: 2 additions & 2 deletions modules/log4j-configurator/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,12 @@
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-logging</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-log4j-boot-configurator</artifactId>
<version>${project.version}</version>
</dependency>
Expand Down
1 change: 1 addition & 0 deletions modules/logging/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
<artifactId>mule-modules</artifactId>
<version>4.7.0-SNAPSHOT</version>
</parent>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-logging</artifactId>
<packaging>jar</packaging>
<name>Mule Logging</name>
Expand Down
3 changes: 2 additions & 1 deletion modules/reboot/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<groupId>org.mule.runtime</groupId>
<version>4.7.0-SNAPSHOT</version>
</parent>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-reboot</artifactId>
<packaging>jar</packaging>
<name>Mule 4 Container</name>
Expand All @@ -18,7 +19,7 @@

<dependencies>
<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-boot-api</artifactId>
<version>${project.version}</version>
</dependency>
Expand Down
2 changes: 1 addition & 1 deletion modules/service/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
</dependency>

<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-jpms-utils</artifactId>
<version>${project.version}</version>
</dependency>
Expand Down
2 changes: 1 addition & 1 deletion modules/spring-config/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@

<!-- Add logging libraries required by spring -->
<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-logging</artifactId>
<version>${project.version}</version>
</dependency>
Expand Down
5 changes: 3 additions & 2 deletions modules/tanuki-boot/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<groupId>org.mule.runtime</groupId>
<version>4.7.0-SNAPSHOT</version>
</parent>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-tanuki-boot</artifactId>
<packaging>jar</packaging>
<name>Mule 4 Container Wrapper based on Tanuki</name>
Expand All @@ -18,12 +19,12 @@

<dependencies>
<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-boot-api</artifactId>
<version>${project.version}</version>
<exclusions>
<exclusion>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-log4j-boot-configurator</artifactId>
</exclusion>
</exclusions>
Expand Down
2 changes: 1 addition & 1 deletion tests/runner/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
</dependency>

<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-logging</artifactId>
<version>${project.version}</version>
<scope>provided</scope>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,6 @@
*/
package org.mule.test.runner.api;

import static org.mule.maven.client.api.MavenClientProvider.discoverProvider;

import static java.util.Collections.emptyList;
import static java.util.Objects.requireNonNull;
import static java.util.Optional.empty;
Expand All @@ -16,8 +14,6 @@
import static com.google.common.base.Joiner.on;
import static org.eclipse.aether.util.artifact.ArtifactIdUtils.toId;

import org.mule.maven.client.api.MavenClient;
import org.mule.maven.client.api.MavenClientProvider;
import org.mule.maven.client.api.model.MavenConfiguration;
import org.mule.maven.client.internal.MuleMavenRepositoryState;
import org.mule.maven.client.internal.MuleMavenRepositoryStateFactory;
Expand Down Expand Up @@ -385,11 +381,13 @@ private Pair<List<File>, List<File>> getContainerFiles(DependencyNode node) {
// Implementation note: this must be kept consistent with the equivalent logic in embedded-api and the distro assemblies
private boolean isMuleContainerGroupId(final String groupId) {
return groupId.equals("org.mule.runtime")
|| groupId.equals("org.mule.runtime.boot")
|| groupId.equals("org.mule.sdk")
|| groupId.equals("org.mule.weave")
|| groupId.equals("org.mule.mvel")
|| groupId.equals("org.mule.commons")
|| groupId.equals("com.mulesoft.mule.runtime")
|| groupId.equals("com.mulesoft.mule.runtime.boot")
|| groupId.equals("com.mulesoft.mule.runtime.modules")
|| groupId.equals("com.mulesoft.anypoint");
}
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
</dependency>

<dependency>
<groupId>org.mule.runtime</groupId>
<groupId>org.mule.runtime.boot</groupId>
<artifactId>mule-module-logging</artifactId>
<version>${project.version}</version>
</dependency>
Expand Down

0 comments on commit ef9680b

Please sign in to comment.