Fix/w 10673625 #193
Draft
Fix/w 10673625 #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konangc87
reviewed
Jul 7, 2022
| @@ -50,7 +51,7 @@ public static URI createUri(String basePath, String filePath) { | |||
| String fullPath; | |||
| try { | |||
| if (filePath.length() > 0) { | |||
| if (isAbsolute(filePath)) { | |||
| if (isAbsolute(filePath) || basePath.isEmpty()) { | |||
There was a problem hiding this comment.
what will happen if the filePath is not an absolute path and the basePath is empty? will the URI constructor throw an exception?
| public void bothConstructorWithBasePathAssignInSpecificFolderWithSeparator2() { | ||
| ConcreteFileAttributes pathAttributes = new ConcreteFileAttributes(Paths.get("/myFile.txt")); | ||
| // Basepath parameter will be ignored when tne filepath is absolute (when it start with slash) | ||
| ConcreteFileAttributes uriAttributes = new ConcreteFileAttributes(createUri("/root/", "/myFile.txt")); |
There was a problem hiding this comment.
in this case I would expect the result as "/root/myfile.txt", the condition to check if the path is absolute checks only that the filePath started with a "/" but that doesn't mean that the path is absolute right? in Unix I would expect a "~/" to determine that the path is absolute and in Windows I would expect a "X:"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.