This repository has been archived by the owner on Oct 17, 2019. It is now read-only.
Retry initial sync forever #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for the PR! We would like to retry indefinitely as long as the result from calling /sync is 504 (Gateway Timeout). If any other error occurs we should stop syncing and fallback to the login screen. You could modify this signal to return the status code and based on that you decide whether or not to continue. |
This was referenced Feb 23, 2018
vurpo
pushed a commit
to vurpo/nheko
that referenced
this pull request
Jun 28, 2018
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing #233
I haven't been able to test more than two initial syncs locally, I hope that someone with a larger account can give it a go!