Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Update Babel config to match closer to Core #14350

Closed

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 26, 2024

Replicate mui/material-ui#43286. I got confused by this comment: "This change is already done in X but I haven't had time to do it here as well." I didn't see where.

Preview: https://deploy-preview-14350--material-ui-x.netlify.app/x/react-data-grid/

@oliviertassinari oliviertassinari changed the title [core-infra] Update Babel config to match closer to Core [code-infra] Update Babel config to match closer to Core Aug 26, 2024
@oliviertassinari oliviertassinari added the scope: code-infra Specific to the core-infra product label Aug 26, 2024
@mui-bot
Copy link

mui-bot commented Aug 26, 2024

Deploy preview: https://deploy-preview-14350--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 1346108

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 26, 2024

Arf, the CI fails, harder than I thought.

@romgrk
Copy link
Contributor

romgrk commented Aug 27, 2024

I got confused by this comment: "This change is already done in X but I haven't had time to do it here as well." I didn't see where.

There should be a [core] PR on MUI-X with the same change, a while ago. Not sure if I used { loose: true } or the assumptions. I don't think it's worth messing with the config as long as we're already using { loose: true }.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 27, 2024

It would be great to align the babel config to all be the same, something broke when I did it, but yeah, no time on my end to dive into what broke. We use loose, it's likely ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance scope: code-infra Specific to the core-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants