Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Remove outdated ENABLE_AD env variable #11181

Merged
merged 1 commit into from
Nov 26, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Nov 25, 2023

I'm not sure what went wrong on this one, but it's likely when we refactored the logic to move the value to ENABLE_AD_IN_DEV_MODE abstracted under the docs infra that we lost track of this value.

Related to #10795

@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Nov 25, 2023
@mui-bot
Copy link

mui-bot commented Nov 25, 2023

Deploy preview: https://deploy-preview-11181--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 23f43e6

@oliviertassinari oliviertassinari changed the title [core] Remove outdated env variable [core] Remove outdated ENABLE_AD env variable Nov 25, 2023
@oliviertassinari oliviertassinari changed the title [core] Remove outdated ENABLE_AD env variable [core] Remove outdated ENABLE_AD env variable Nov 25, 2023
@oliviertassinari oliviertassinari added the scope: docs-infra Specific to the docs-infra product label Nov 25, 2023
@oliviertassinari oliviertassinari merged commit 295518d into mui:next Nov 26, 2023
19 checks passed
@oliviertassinari oliviertassinari deleted the remove-dead-variable branch November 26, 2023 11:03
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Nov 26, 2023

Normally, all the Next.js new warnings are covered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants