[Left Nav] Fix left nav opening on click

[pomerantsev]

Fixes #997

[cgestes]

Hi pomerantsev,

Thank you for the fix.
But does not seem to work on my phone. (android) (no swiping at all can be observed with the patch)

[pomerantsev]

@cgestes: if you're sure the issue has been introduced by this patch, could you please describe it in more detail?
Swiping works fine for me in Chrome on Google Nexus 5 and Samsung Galaxy S5, and in Safari on an iPod 5.
Swiping does not work perfectly though in the Android stock browser on the Samsung Galaxy S5 (you have to be sure while swiping left or right that you haven't moved up or down at all), and it probably has to do with constants (how far you should swipe to consider it a gesture). I will make a separate issue for this.
But I wonder how this could have anything to do with the patch, since I've only changed code in the touchend handler.

[cgestes]

I'am using it in cordova. (galaxy s4 mini).

will try in Chrome.

The issue is simple: it doesn't do anything, which is much better than the previous crazyness :)

I plan to spend some time debugging material-ui on the phone. (swiping, ListItem ripple, ..)

So it's better with the patch.

[cgestes]

it's working in Chrome on my phone :)

[cgestes]

same for the ListItem!

I will have to debug what happens with the default browser. (android 4.4)

[pomerantsev]

Okay, cool.
@hai-cea: looks like @cgestes approves this PR :).
@cgestes: I'm going to take a look at what's going on in the stock browser, but it won't happen until Sunday. If you narrow it down before that, please feel free to submit an issue, and I'll be happy to fix it.

[hai-cea]

Thanks @pomerantsev @cgestes !

[pomerantsev]

@cgestes: I spent some time trying to figure out what was causing the issue. Now I think I understand what's going on, but I still don't have a solution.
The stock Android browser on my Samsung Galaxy S5 reports that it's based on Chrome 34, and the way touch events behave changed in Chrome 35: http://lists.w3.org/Archives/Public/public-touchevents/2014Mar/0000.html
Thing is, prior to version 35, as soon as the page fires a scroll event, a touchcancel event also fires, and all subsequent touch events are suppressed.
We could call e.preventDefault() between these two lines, and swiping would work fine, but then the page wouldn't scroll at all (looks like this way scroll events are suppressed), so this is not a solution.
Summary: this bug is not critical (users can still use clicks to close the nav), and fixing it seems like a major pain, so I'll leave it as it is.
Feel free to open a new issue if there's anything I haven't addressed here.

[cgestes]

@pomerantsev thanks for the investigation.