Merge snackbar styles when closed as well as open #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inline styles aren't being overridden when the snackbar is closing because they were only merged when it was open. This fixes that. It still doesn't give a good way to add your own, different styles for opening and closing though.
|
Good call, using the ternary now |
|
Thanks @lourd |
hai-cea
added a commit
that referenced
this pull request
Jun 24, 2015
Merge snackbar styles when closed as well as open
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
* [mui#925] [mui#930] Support views and openTo props for InlineDatePicker * [mui#929] Fix openTo prop always recognizing as year * [mui#925] Rerun getDisplayDate on labelFunc change * Add onMonthChange and onYearChange callbacks * Pass new callbacks also for DateTimePicker * Move firing onYearChange to YearSelection
zannager
added
the
component: snackbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline styles aren't being overridden when the snackbar is closing because they were only merged when it was open. This fixes that. It still doesn't give a good way to add your own, different styles for opening and closing though.