cosmetic fixes to textfield/select-field #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chrismcv
commented
Jun 23, 2015
chrismcv
commented
- unsetting errorText prop should remove error text
- When selecting an item from select-field e.target.value should be the value not the payload
- Menu calculation didn't work when menuItems are changed/supplied after mount.
|
@chrismcv Looks like this PR broke SelectField menu: |
|
apologies... fixed |
|
@chrismcv Can you rebase please? |
|
yip done |
|
@chrismcv - Looks like something weird with the LeftNav now. |
… being actually used. renamed showRowSelectCheckbox to displayRowCheckbox
|
Sorry again... should be fixed now.... also fixes eslint on windows, and a On Wed, Jun 24, 2015 at 4:13 PM Hai Nguyen notifications@github.com wrote:
|
|
should be done, |
hai-cea
added a commit
that referenced
this pull request
Jun 24, 2015
cosmetic fixes to textfield/select-field
|
great! Thanks @chrismcv 👍 |
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
By replacing `@class` annotation with `@__PURE__` we broke rollup internal sourcemap generator. Found the fix here https://github.com/ex-machine/rollup-plugin-ts-treeshaking/blob/master/index.js
zannager
added
component: select
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.