[Tab] Applies muiTheme to Tab component. #889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 19, 2015 15:37
Merged default tab styles into the light-theme and set the inline styles for the tab component based on those theme properties.
|
Cool, just pushed a commit to better adhere to the pattern. Let me know what you think. |
| fontWeight': '500', | ||
| whiteSpace': 'initial', | ||
| boxSizing': 'border-box' | ||
| }, |
There was a problem hiding this comment.
Also, I would rather keep this clean and only have styles that are relevant to override.
There was a problem hiding this comment.
Which would you like me to remove?
There was a problem hiding this comment.
I guess we should just keep color? If a developer needs to override these other items, they can pass in a style prop which should get merged in with default styles.
hai-cea
changed the title
mnajdova
pushed a commit
to mnajdova/material-ui
that referenced
this pull request
Nov 10, 2020
* Move running tests to the circleci * Format config.yml * Fix incorrect running command for circleci * Add lerna bootstrap to installation process on circleci * Fix incorrect lerna call in running app * Refactor Calednar.tsx * Calculate animation direction on moving with keyboard * Prevent changing slide direction if month wasn't changed
zannager
added
the
component: tabs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed that the Tab component did not pick up any theme overrides. This should allow you to style them from your custom theme.
Thanks.