optional content in left nav #485
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks like a duplicate of #383. |
|
I did not see that one. It sure looks similar, thank you for the notice. |
|
@johnedvard everything was done correctly. Your pull request looks great! As @hai-cea mentions in #383, list-related components will be revamped after our css-refactoring is complete, and this is definitely a change we plan to include. This pull request will be closed because it is a duplicate of #383. However, I encourage you to continue submitting new pull requests when you feel they are needed. We are very open to contributions and suggestions! I'm looking forward to seeing what changes you will bring to material-ui :) |
zannager
added
component: bottom navigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now able to add your own react elements into the left-nav.
PS: This is my first pull request ever, so I am not sure if I am doing it correctly.
I also want to say that I am using the left-nav in my own project, and I am using it for something else than a navigation menu. I found that the current solution is a good for adding my own elements into the left-nav. Maybe it is useful for others as well.
(an example can be seen in the image, where "This is a test" is added as optional content in the left-nav)