Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Menu,Popover] Fix Backdrop props descriptions #43503

Conversation

Michael-Hutchinson
Copy link
Contributor

fix: update popover component with deprecated props and types

Closes: 43222

@mui-bot
Copy link

mui-bot commented Aug 28, 2024

Netlify deploy preview

https://deploy-preview-43503--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 96a2ebe

@zannager zannager added component: menu This is the name of the generic UI component, not the React module! component: Popover The React component. labels Aug 29, 2024
@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work package: material-ui Specific to @mui/material customization: slot Component's slot customizability labels Aug 30, 2024
@ZeeshanTamboli ZeeshanTamboli changed the title [material-ui][Menu,Popover] slotProps cannot modify backdrop slot [material-ui][Menu,Popover] Fix Backdrop props descriptions Aug 30, 2024
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@ZeeshanTamboli ZeeshanTamboli merged commit 8b8732e into mui:master Aug 30, 2024
22 checks passed
@Michael-Hutchinson Michael-Hutchinson deleted the fix/slotProps-cannot-modify-backdrop-slot branch August 30, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: menu This is the name of the generic UI component, not the React module! component: Popover The React component. customization: slot Component's slot customizability package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[material-ui][Menu,Popover] slotProps cannot modify backdrop slot
4 participants