Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Remove permissions in publish-canaries.yml #43491

Merged

Conversation

oliviertassinari
Copy link
Member

It looks like this GitHub action doesn't need GITHUB_TOKEN with permissions to our GitHub repository APIs. Flagged in https://github.com/mui/material-ui/security/code-scanning/69.

@oliviertassinari oliviertassinari added security Pull requests that address a security vulnerability scope: code-infra Specific to the core-infra product labels Aug 28, 2024
@mui-bot
Copy link

mui-bot commented Aug 28, 2024

Netlify deploy preview

https://deploy-preview-43491--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against b3604ef

Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it won't complain about contents: read, but maybe not since the repo is public.

@oliviertassinari oliviertassinari merged commit eea5079 into mui:master Aug 30, 2024
21 checks passed
@oliviertassinari oliviertassinari deleted the reset-permissions-cannary branch August 30, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: code-infra Specific to the core-infra product security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants