[docs-infra] Fix use of process.env.DEPLOY_ENV #43490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
changed the title
oliviertassinari
added
bug 🐛
Netlify deploy previewhttps://deploy-preview-43490--material-ui.netlify.app/ Bundle size report |
alexfauquette
approved these changes
Aug 28, 2024
@alexfauquette They seem useful for new initiatives, when we are working our way toward product-market fit, we need to amplify any small feedback we can get. Also to spot obvious mistakes. After that, it's always more important to focus on 1. PR signal 2. issues signal, etc. These feedback become too easy to leave so doesn't tell enough about the intensity of the pain. @samuelsycamore but maybe something to have in https://www.notion.so/mui-org/Head-of-Docs-49a20cef18dc4ccf8e6f50794964a144?pvs=4#cb890daeee8e4bdeb595c8f9a896f2a8? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That check looked wrong to me. We have an env variable for this, which is replaced at build-time, so less bundle size, and that is more predictable.
(Initially added by Matt)